go/hcl
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

zcl: Range.String should not be a pointer method

Browse Source 
We don't usually use ranges as pointers, except in diagnostics.
This commit is contained in:
Martin Atkins 2017-06-11 08:37:28 -07:00
parent cb768a591a
commit e571ec5810
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zcl/pos.go
View File

@ -77,7 +77,7 @@ func (r Range) Ptr() *Range {
// String returns a compact string representation of the receiver. // String returns a compact string representation of the receiver.
// Callers should generally prefer to present a range more visually, // Callers should generally prefer to present a range more visually,
// e.g. via markers directly on the relevant portion of source code. // e.g. via markers directly on the relevant portion of source code.
func (r *Range) String() string { func (r Range) String() string {
if r.Start.Line == r.End.Line { if r.Start.Line == r.End.Line {
return fmt.Sprintf( return fmt.Sprintf(
"%s:%d,%d-%d", "%s:%d,%d-%d",