hcl/hclsyntax
Martin Atkins 63e2897c12 hclsyntax: Source range of IndexExpr must cover whole expression
Some HCL callers make the (reasonable) assumption that the overall source
range of an expression will be a superset of all of the ranges of its
child expressions, for purposes such as extraction of source code
snippets, parse tree annotation in hclwrite, text editor analysis
functions like "go to reference", etc.

The IndexExpr type was not previously honoring that assumption, since its
source range was placed around only the bracket portion. That is a good
region to use when reporting errors relating to the index operation, but
it is not a faithful representation of the full extent of the expression.

In order to meet both of these requirements at once, IndexExpr now has
both SrcRange covering the entire expression and BracketRange covering
the index part delimited by brackets. We can then use BracketRange in
our error messages but return SrcRange as the result of the general
Range method that is common to all expression types.
2019-12-06 09:09:18 -08:00
..
fuzz Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
diagnostics.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
didyoumean_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
didyoumean.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
doc.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
expression_ops.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
expression_static_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
expression_template_test.go hclsyntax: Additional tests for template sequence escapes 2019-10-01 15:59:10 -07:00
expression_template.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
expression_test.go hclsyntax: Allow parens to force mapping key to be expression 2019-10-01 15:59:10 -07:00
expression_vars_gen.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
expression_vars.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
expression.go hclsyntax: Source range of IndexExpr must cover whole expression 2019-12-06 09:09:18 -08:00
file.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
generate.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
keywords.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
navigation_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
navigation.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
node.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
parse_traversal_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
parser_template.go hclwrite: Allow selecting blocks for updating 2019-10-01 15:59:10 -07:00
parser_test.go hclsyntax: Source range of IndexExpr must cover whole expression 2019-12-06 09:09:18 -08:00
parser_traversal.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
parser.go hclsyntax: Source range of IndexExpr must cover whole expression 2019-12-06 09:09:18 -08:00
peeker_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
peeker.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
public_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
public.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
scan_string_lit_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
scan_string_lit.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
scan_string_lit.rl Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
scan_tokens_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
scan_tokens.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
scan_tokens.rl Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
spec.md hclsyntax: Include legacy index syntax in the specification 2019-10-01 15:59:10 -07:00
structure_at_pos_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
structure_at_pos.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
structure_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
structure.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
token_type_string.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
token.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
unicode2ragel.rb Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
unicode_derived.rl Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
variables_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
variables.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
walk_test.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00
walk.go Unfold the "hcl" directory up into the root 2019-09-09 16:08:19 -07:00