hcl/json/public_test.go
Alisdair McDiarmid b265bbd046 json: Fix panic when parsing malformed JSON
When scanning JSON, upon encountering an invalid token, we immediately
return. Previously this return happened without inserting an EOF token.
Since other functions assume that a token sequence always ends in EOF,
this could cause a panic.

This commit adds a synthetic EOF token after the invalid token before
returning. While this does not match the real end-of-file of the source
JSON, it is marking the end of the scanned bytes, so it seems reasonable.

Fixes #339
2020-03-25 16:40:36 -04:00

115 lines
2.8 KiB
Go

package json
import (
"strings"
"testing"
"github.com/hashicorp/hcl/v2"
"github.com/zclconf/go-cty/cty"
)
func TestParse_nonObject(t *testing.T) {
src := `true`
file, diags := Parse([]byte(src), "")
if len(diags) != 1 {
t.Errorf("got %d diagnostics; want 1", len(diags))
}
if file == nil {
t.Errorf("got nil File; want actual file")
}
if file.Body == nil {
t.Fatalf("got nil Body; want actual body")
}
if file.Body.(*body).val == nil {
t.Errorf("got nil Body object; want placeholder object")
}
}
func TestParseTemplate(t *testing.T) {
src := `{"greeting": "hello ${\"world\"}"}`
file, diags := Parse([]byte(src), "")
if len(diags) != 0 {
t.Errorf("got %d diagnostics on parse; want 0", len(diags))
for _, diag := range diags {
t.Logf("- %s", diag.Error())
}
}
if file == nil {
t.Errorf("got nil File; want actual file")
}
if file.Body == nil {
t.Fatalf("got nil Body; want actual body")
}
attrs, diags := file.Body.JustAttributes()
if len(diags) != 0 {
t.Errorf("got %d diagnostics on decode; want 0", len(diags))
for _, diag := range diags {
t.Logf("- %s", diag.Error())
}
}
val, diags := attrs["greeting"].Expr.Value(&hcl.EvalContext{})
if len(diags) != 0 {
t.Errorf("got %d diagnostics on eval; want 0", len(diags))
for _, diag := range diags {
t.Logf("- %s", diag.Error())
}
}
if !val.RawEquals(cty.StringVal("hello world")) {
t.Errorf("wrong result %#v; want %#v", val, cty.StringVal("hello world"))
}
}
func TestParseTemplateUnwrap(t *testing.T) {
src := `{"greeting": "${true}"}`
file, diags := Parse([]byte(src), "")
if len(diags) != 0 {
t.Errorf("got %d diagnostics on parse; want 0", len(diags))
for _, diag := range diags {
t.Logf("- %s", diag.Error())
}
}
if file == nil {
t.Errorf("got nil File; want actual file")
}
if file.Body == nil {
t.Fatalf("got nil Body; want actual body")
}
attrs, diags := file.Body.JustAttributes()
if len(diags) != 0 {
t.Errorf("got %d diagnostics on decode; want 0", len(diags))
for _, diag := range diags {
t.Logf("- %s", diag.Error())
}
}
val, diags := attrs["greeting"].Expr.Value(&hcl.EvalContext{})
if len(diags) != 0 {
t.Errorf("got %d diagnostics on eval; want 0", len(diags))
for _, diag := range diags {
t.Logf("- %s", diag.Error())
}
}
if !val.RawEquals(cty.True) {
t.Errorf("wrong result %#v; want %#v", val, cty.True)
}
}
func TestParse_malformed(t *testing.T) {
src := `{
"http_proxy_url: "http://xxxxxx",
}`
file, diags := Parse([]byte(src), "")
if got, want := len(diags), 2; got != want {
t.Errorf("got %d diagnostics; want %d", got, want)
}
if err, want := diags.Error(), `Missing property value colon`; !strings.Contains(err, want) {
t.Errorf("diags are %q, but should contain %q", err, want)
}
if file == nil {
t.Errorf("got nil File; want actual file")
}
}